RFR: 8316206: Test StretchedFontTest.java fails for Baekmuk font [v2]
Phil Race
prr at openjdk.org
Thu Sep 21 18:48:46 UTC 2023
On Wed, 20 Sep 2023 14:07:17 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> **Root cause**
>>
>> The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has zero length.
>>
>> The test fails if the right half of the image with the rendered glyph contains only pixels of background colour. In this case, the left half of the image is also blank. It's somewhat false positive because of the broken font.
>>
>> **Fix**
>>
>> Ignore fonts which don't render the glyph correctly. If the left half of the image contains pixels of the background colour only, it is expected that the right half also contains background-coloured pixels only.
>>
>> The updated test does not fail with the _Baekmuk Headline_ font. It still detects the original problem and fails on builds without the fix for [JDK-8312555](https://bugs.openjdk.org/browse/JDK-8312555).
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8316206: Use GlyphVector.getVisualBounds().isEmpty()
>
> Filter out broken fonts by GlyphVector.getVisualBounds().isEmpty()
Marked as reviewed by prr (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/15818#pullrequestreview-1638492044
More information about the client-libs-dev
mailing list