RFR: 8316053: Open some swing tests 3 [v2]

[Damon Nguyen]

On Thu, 21 Sep 2023 19:03:08 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Moving tests from closed to open
>> 8 javax/swing/SwingGraphics/VolatileBackBuffer/MultimonVImage.java
>> 9 javax/swing/SwingUtilities/4859570/bug4859570.java
>> 10 javax/swing/SwingUtilities/4936652/bug4936652.java
>> 11 javax/swing/ToolTipManager/4768127/bug4768127.java
>
> Alisen Chung has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - waitForIdle first
>  - typo
>  - updated based on comment feedback

test/jdk/javax/swing/JDialog/bug4859570.java line 40:

> 38: public class bug4859570 {
> 39:     static volatile boolean dialogIsClosed = false;
> 40:     static Robot r;

Pretty sure robot can be local.

test/jdk/javax/swing/JDialog/bug4859570.java line 66:

> 64:         if (!dialogIsClosed) {
> 65:             r.delay(1000);
> 66:         }

Do you know if dialogIsClosed is needed? It seems to only add a delay. I suppose this makes more sense when there was `synchronized`, but not sure if it's still needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15851#discussion_r1333538880
PR Review Comment: https://git.openjdk.org/jdk/pull/15851#discussion_r1333538268