RFR: 8316146: Open some swing tests 4

[Harshitha Onkar]

On Thu, 21 Sep 2023 22:00:27 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Opening closed tests:
> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
> 15 javax/swing/plaf/metal/4306431/bug4306431.java

Looks good except for some minor nits as mentioned below.

test/jdk/javax/swing/BasicMenuUI/bug4244616.java line 52:

> 50: 
> 51:         // Stream redirection
> 52:         try(ByteArrayOutputStream bout = new ByteArrayOutputStream();

Minor
Suggestion:

        try (ByteArrayOutputStream bout = new ByteArrayOutputStream();

test/jdk/javax/swing/ToolTipManager/bug5078214.java line 109:

> 107:             Util.blockTillDisplayed(mainFrame);
> 108:             r.delay(1000);
> 109:             r.waitForIdle();

first r.waitForIdle(), followed by r.delay().

test/jdk/javax/swing/ToolTipManager/bug5078214.java line 113:

> 111:             test(bounds, insets);
> 112:             r.delay(1000);
> 113:             r.waitForIdle();

Same here.

-------------

Marked as reviewed by honkar (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15875#pullrequestreview-1638776321
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1333648588
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1333651292
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1333651475