RFR: 8316371: Open some swing tests 6

Phil Race prr at openjdk.org
Thu Sep 21 23:05:13 UTC 2023


On Thu, 21 Sep 2023 21:45:49 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Opening some closed tests:
> 20 javax/swing/plaf/windows/4736093/bug4736093.java
> 21 javax/swing/table/DefaultTableCellRenderer/4240870/bug4240870.java
> 22 javax/swing/table/JTableHeader/4243927/bug4243927.java
> 23 javax/swing/text/AbstractDocument/4549069/bug4549069.java
> 24 javax/swing/text/AbstractWriter/4185537/bug4185537.java

test/jdk/javax/swing/AbstractDocument/bug4549069.java line 84:

> 82:                 f.setVisible(true);
> 83: 
> 84:                 if (!passed) {

I'm not sure why this var is tested here. The test sets it to true in a static initializer and NEVER updates it.
I think the test is supposed to fail if an Exception is thrown so this isn't needed, unless there's some place it is supposed to update the var on catching an Exception but I don't see that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15873#discussion_r1333678728


More information about the client-libs-dev mailing list