RFR: 8316211: Open source several manual applet tests [v2]

Andrey Turbanov aturbanov at openjdk.org
Fri Sep 22 07:04:13 UTC 2023


On Wed, 20 Sep 2023 01:46:35 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Open sourcing several manual applet tests
>> 
>> 
>> test/jdk/java/awt/Frame/DefaultSizeTest.java
>> test/jdk/java/awt/LightweightComponent/LightweightCliprect.java
>> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java
>> test/jdk/javax/swing/JFrame/DefaultCloseOperation.java
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   FunctionKeyTest converted to automated

test/jdk/java/awt/Frame/DefaultSizeTest.java line 35:

> 33:  */
> 34: 
> 35: public class DefaultSizeTest  {

Suggestion:

public class DefaultSizeTest {

test/jdk/java/awt/LightweightComponent/LightweightCliprect.java line 96:

> 94:         for(int i = 0; i < 30; i++) {
> 95:             g.drawString("Lightweight: Java version: " + version +
> 96:                          ", Vendor: " + vendor,  10, y += 20);

Suggestion:

                         ", Vendor: " + vendor, 10, y += 20);

test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java line 104:

> 102: class FunctionKeyTester extends Frame {
> 103:     Label l = new Label ("NULL");
> 104:     Button b =  new Button ();

Suggestion:

    Button b = new Button ();

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15827#discussion_r1333962044
PR Review Comment: https://git.openjdk.org/jdk/pull/15827#discussion_r1333962295
PR Review Comment: https://git.openjdk.org/jdk/pull/15827#discussion_r1333961842


More information about the client-libs-dev mailing list