RFR: 8316389: Open source few AWT applet tests [v5]
Alexey Ivanov
aivanov at openjdk.org
Mon Sep 25 15:38:31 UTC 2023
On Mon, 25 Sep 2023 15:27:15 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>> Open sourcing few tests:
>>
>> java/awt/Frame/FrameRepackTest.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
>> java/awt/Frame/WindowMoveTest.java
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>
> space removed
test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java line 87:
> 85: super("FrameResize_2");
> 86:
> 87: setLayout( new GridBagLayout() );
Suggestion:
setLayout(new GridBagLayout());
test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java line 94:
> 92: c.weighty = 1;
> 93:
> 94: Container dumbc = new DumbC();
Maybe change names of `dumbc` and `dump` to `container` and `panel`?
test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java line 118:
> 116: }
> 117:
> 118: class DumbC extends Container {
Suggestion:
class DumbContainer extends Container {
Similarly, to `DumbPanel`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15787#discussion_r1336063216
PR Review Comment: https://git.openjdk.org/jdk/pull/15787#discussion_r1336065512
PR Review Comment: https://git.openjdk.org/jdk/pull/15787#discussion_r1336064508
More information about the client-libs-dev
mailing list