RFR: 8316389: Open source few AWT applet tests [v6]
Alexey Ivanov
aivanov at openjdk.org
Mon Sep 25 17:51:34 UTC 2023
On Mon, 25 Sep 2023 17:21:13 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>> Open sourcing few tests:
>>
>> java/awt/Frame/FrameRepackTest.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
>> java/awt/Frame/WindowMoveTest.java
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>
> review comments
Marked as reviewed by aivanov (Reviewer).
test/jdk/java/awt/Frame/WindowMoveTest.java line 57:
> 55: frame.dispatchEvent(new WindowEvent(frame, WindowEvent.WINDOW_CLOSING)));
> 56:
> 57: if (!WindowMove.latch.await(10, TimeUnit.SECONDS)) {
I think 10 seconds is too long… We usually use 2 seconds for various delays.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15787#pullrequestreview-1642681652
PR Review Comment: https://git.openjdk.org/jdk/pull/15787#discussion_r1336198201
More information about the client-libs-dev
mailing list