RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java [v2]
Alexey Ivanov
aivanov at openjdk.org
Wed Sep 27 11:51:16 UTC 2023
On Wed, 27 Sep 2023 08:04:02 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>>> Yet keeping tests in the same area closer seems like a good idea to me. Either line is fine with me.
>>
>> Let's go for the latter one, line 416.
>>
>>> I started an internal discussion in clientlibs to see whether there are any conventions.
>>
>> It looks there are no strict conventions. There groups for *awt* and *swing*, there are also some subheaders to group tests which fail with the same root cause, like the one above the line you're adding.
>>
>> At the same time, I still think it's better to group tests… This one is in `awt/font`, let's add close to another one.
>>
>> Other than that, it looks good to me, I'll approve it.
>
> OK, great. I've moved the exclusion to the proposed line. Thanks for checking.
Thank you, Christoph!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15880#discussion_r1338482530
More information about the client-libs-dev
mailing list