RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v2]

[Damon Nguyen]

On Fri, 29 Sep 2023 05:05:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test was run without waiting for UI to be made visible leading to IllegalComponentStateException.
>> Used robot.delay consistent with other headful tests to made the test wait after UI is created and shown.
>> 
>> Test passed in several iterations in all platforms. Link in JBS
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add setAutoWaitForIdle

Stability changes with delays/waits look good. Minor nit.

test/jdk/javax/swing/JMenuItem/4654927/bug4654927.java line 96:

> 94:                 @Override
> 95:                 public Point call() throws Exception {
> 96:                     System.out.println("Menu Location: "+ menu.getLocationOnScreen());

Suggestion:

                    System.out.println("Menu Location: " + menu.getLocationOnScreen());

test/jdk/javax/swing/JMenuItem/4654927/bug4654927.java line 105:

> 103:                 @Override
> 104:                 public Point call() throws Exception {
> 105:                     System.out.println("MenuItem Location: "+ menuItem.getLocationOnScreen());

Suggestion:

                    System.out.println("MenuItem Location: " + menuItem.getLocationOnScreen());

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15677#pullrequestreview-1651107520
PR Review Comment: https://git.openjdk.org/jdk/pull/15677#discussion_r1341564697
PR Review Comment: https://git.openjdk.org/jdk/pull/15677#discussion_r1341564855