RFR: 8316146: Open some swing tests 4 [v6]

Alexey Ivanov aivanov at openjdk.org
Fri Sep 29 19:31:39 UTC 2023


On Fri, 29 Sep 2023 19:31:08 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15 javax/swing/plaf/metal/4306431/bug4306431.java
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed skippedexception, fixed comment

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/ToolTipManager/bug5078214.java line 66:

> 64:                         "with the taskbar at the bottom position.");
> 65:             }
> 66:             bounds = getGraphicsConfig().getBounds();

It's better to use the pattern that was used before: assign the result of `getGraphicsConfig()` to `testConfig` because `getGraphicsConfig()` is not a simple getter which returns the value of a field. On the other hand, it's more like premature optimisation; it's unlikely that enumerating screens takes a lot of time, especially now when you use the default config only.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15875#pullrequestreview-1651371634
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1341727276


More information about the client-libs-dev mailing list