RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v4]

Harshitha Onkar honkar at openjdk.org
Mon Apr 1 21:32:04 UTC 2024


On Thu, 22 Feb 2024 06:35:19 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JTabbedPane's content area, tab area and tab background color are not as expected when opaque is set to true or false. 
>> The proposed fix is to handle the TabbedPane's background color in installed LAFs. Manual test is added to support the fix and there is no regression caused by the fix. 
>> 
>> Proposed fix is tested in Ubuntu 22.04 and Oracle linux.
>> 
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   condition combined

Changes requested by honkar (Reviewer).

test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 72:

> 70: 
> 71:     public static void main(String[] args) throws Exception {
> 72:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

Test needs to be updated as per the new PassFailJFrame builder changes. 

`PassFailJFrame.builder()`

-------------

PR Review: https://git.openjdk.org/jdk/pull/17720#pullrequestreview-1972154155
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1546866413


More information about the client-libs-dev mailing list