RFR: 8329340: Remove unused libawt code

[Alexey Ivanov]

On Fri, 29 Mar 2024 18:23:27 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this PR that removes unused functions, variables, and WM_AWT window messages.
> 
> The unused code was detected by automated analysis (MSVC compiler and linker, CodeQL analyzer). I manually verified every symbol before removing. Mach5 client libs testing clean.
> 
> Some WM_AWT messages have different IDs after this change. The IDs have changed a few times before, so I think this shouldn't be a problem.

Looks good to me.

src/java.desktop/windows/native/libawt/windows/awt_Debug.cpp line 111:

> 109:  * DTRACE print callback to dump window's update region bounding rectangle
> 110:  */
> 111: void DumpUpdateRectangle(const char * file, int line, int argc, const char * fmt, va_list arglist) {

Can these functions be useful for debugging?

Does it make sense to hide them unless `DEBUG` is defined?

src/java.desktop/windows/native/libawt/windows/awtmsg.h line 224:

> 222: 
> 223:     /* deleted DND mesg's */
> 224: 

I guess this comment can safely be removed. What does it add? There had been some messages that were removed a long time ago.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18553#pullrequestreview-1973710651
PR Review Comment: https://git.openjdk.org/jdk/pull/18553#discussion_r1547819832
PR Review Comment: https://git.openjdk.org/jdk/pull/18553#discussion_r1547841399