RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]

Harshitha Onkar honkar at openjdk.org
Tue Apr 2 18:02:30 UTC 2024


On Tue, 2 Apr 2024 17:06:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> It is better to re-throw it as RuntimeException. Updated.
>
>> It is better to re-throw it as RuntimeException. Updated.
> 
> Not really…
> 
> If saving the image fails, we want to preserve *the original error message* which wasn't even thrown by this time. So printing stack trace in this particular is quite safe, the exception could be ignored completely.

Good point. Updated to print stacktrace in case IOException occurs, so as to prevent masking the original more priority test exception.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18523#discussion_r1548326772


More information about the client-libs-dev mailing list