RFR: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected

Abhishek Kumar abhiscxk at openjdk.org
Thu Apr 4 07:11:59 UTC 2024


On Thu, 4 Apr 2024 05:34:18 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test issue shows the End and Start buttons are not placed as per instructions due to ComponentOrientation RTL was not honoured, as with `getContentPane()` being removed from `add` call of JFrame, it was also additionally removed from other JFrame calls which resulted in the RTL not being propagated to its child. Fix is to add `getContentPane()` to the non-add methods of JFrame as was done in the applet version of the test..

Just a minor suggestion, can increase the row count to avoid the scrollbar else looks good to me.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18612#pullrequestreview-1978915124


More information about the client-libs-dev mailing list