RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v7]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Apr 4 12:07:18 UTC 2024


On Thu, 4 Apr 2024 06:55:29 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JTabbedPane's content area, tab area and tab background color are not as expected when opaque is set to true or false. 
>> The proposed fix is to handle the TabbedPane's background color in installed LAFs. Manual test is added to support the fix and there is no regression caused by the fix. 
>> 
>> Proposed fix is tested in Ubuntu 22.04 and Oracle linux.
>> 
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 21653:

> 21651:                <uiProperty name="useBasicArrows" type="BOOLEAN" value="true"/>
> 21652:                <uiProperty name="contentOpaque" type="BOOLEAN" value="true"/>
> 21653:                <uiProperty name="contentAreaColor" type="COLOR">

SInce you are introducing those 3 property in NimbusLookANdFeel, is this defines needed in skin.laf?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1551543921


More information about the client-libs-dev mailing list