RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v7]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Apr 4 17:23:10 UTC 2024


On Thu, 4 Apr 2024 06:55:29 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JTabbedPane's content area, tab area and tab background color are not as expected when opaque is set to true or false. 
>> The proposed fix is to handle the TabbedPane's background color in installed LAFs. Manual test is added to support the fix and there is no regression caused by the fix. 
>> 
>> Proposed fix is tested in Ubuntu 22.04 and Oracle linux.
>> 
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java line 1026:

> 1024:             "TabbedPane.selected", tabbedPaneBg,
> 1025:             "TabbedPane.contentOpaque", Boolean.TRUE,
> 1026:             "TabbedPane.contentAreaColor", tabbedPaneBg,

`TabbedPane.contentOpaque` and `TabbedPane.tabsOpaque` seems to go hand-in-hand and there's another issue for it https://bugs.openjdk.org/browse/JDK-6462396 so if we are supporting one and not other, it may not have desired effect..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1552103661


More information about the client-libs-dev mailing list