RFR: 8328482: Convert and Open source few manual applet test to main based [v9]

[Harshitha Onkar]

On Thu, 4 Apr 2024 17:05:44 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>> 
>> Automated the test SizeMinimizedTest.java. Since the test is failing Linux arch (Maybe related to the bug - [JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915)), the test is problem listed for Linux arch until the issue is fixed/further investigation is done.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments updated - SizeMinimizedTest

Changes requested by honkar (Reviewer).

test/jdk/java/awt/Frame/SizeMinimizedTest.java line 37:

> 35:  * @bug 4065534
> 36:  * @summary Frame.setSize() doesn't change size if window is in an iconified state
> 37:  * @run main/manual SizeMinimizedTest

manual should be removed since it is automated now. 
Does CI Testing look good with the updated test changes?

test/jdk/java/awt/Frame/SizeMinimizedTest.java line 43:

> 41:     private static Frame frame;
> 42:     private static final int INITIAL_WIDTH = 100;
> 43:     private static final int INITIAL_HEIGHT = 100;

Instead of defining width and height separately you can re-use the same constant by defining it as INITIAL_SIZE.
Suggestion:

    private static final int INITIAL_SIZE = 100;

test/jdk/java/awt/Frame/SizeMinimizedTest.java line 47:

> 45:     private static final int INITIAL_Y = 50;
> 46:     private static final int RESET_WIDTH = 200;
> 47:     private static final int RESET_HEIGHT = 200;

Same here, can be renamed as one single constant RESET_SIZE.

test/jdk/java/awt/Frame/SizeMinimizedTest.java line 58:

> 56:         Robot robot = new Robot();
> 57:         try {
> 58:             frame = new Frame("frame size test");

Suggestion:

            frame = new Frame("Frame size test");

test/jdk/java/awt/Frame/SizeMinimizedTest.java line 69:

> 67:                     System.out.println("Initial Frame Location: " + frame.getLocationOnScreen());
> 68:                 }
> 69:             });

This windowlistener should be added before `frame.setVisible(true);` else the initial frame size and location are not logged. 
Moving the creation of UI to a separate method (eg. createUI) makes the code cleaner.

test/jdk/java/awt/Frame/SizeMinimizedTest.java line 84:

> 82:                         }
> 83: 
> 84:                         expectedLoc = new Point(INITIAL_X + OFFSET * iterationCnt, INITIAL_Y);

Please fix line-lengths.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18448#pullrequestreview-1980668081
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1552117771
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1552120607
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1552121767
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1552123280
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1552134912
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1552140246