RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame

Abhishek Kumar abhiscxk at openjdk.org
Mon Apr 8 05:58:13 UTC 2024


On Thu, 4 Apr 2024 12:07:46 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

> Hi Reviewers,
> 
> I have updated the test with PassFailJFrame along with printer availability check. Please review and let me know your suggestions.
> 
> Renjith.

test/jdk/java/awt/print/PageFormat/Orient.java line 38:

> 36:  * @bug 4236095
> 37:  * @summary  Confirm that you get three pages of output, one
> 38:  *           each in portrait, landscape, and reverse landscape

Suggestion:

 *           each in portrait, landscape and reverse landscape

test/jdk/java/awt/print/PageFormat/Orient.java line 47:

> 45: public class Orient implements Printable {
> 46:     private static final String INSTRUCTIONS =
> 47:             "This test will automatically initiate a print.\n\n" +

Can use Text Block style for better readability.

String INSTRUCTIONS = """
...""".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18624#discussion_r1555254968
PR Review Comment: https://git.openjdk.org/jdk/pull/18624#discussion_r1555254794


More information about the client-libs-dev mailing list