RFR: 8326734: text-decoration applied to <span> lost when mixed with <u> or <s>

[Phil Race]

On Tue, 9 Apr 2024 20:09:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/text/html/HTMLDocument/HTMLTextDecoration.java line 62:
>> 
>>> 60:             <p><span style='text-decoration: underline'><s>underline + line-through?</s></span></p>
>>> 61:             <p><span style='text-decoration: underline'><strike>underline + line-through?</strike></span></p>
>>> 62: 
>> 
>> Suppose there's this HTML
>> `<p><s><span style='text-decoration: line-through'>underline + line-through?</span></s></p>`
>> 
>> 
>> ie a strike through is specified in both ways. Does the merge code handle that ? I think it probably does but
>> adding this case to the test might be a good idea.
>
> Because you didn't add the backticks <code>`</code> around your sample, it's interpreted as HTML, and I can't really see it.
> 
> I guess, the code was something line this: `<span style='text-decoration: line-through'><s>`.
> 
> If the both tags have the same value for the `text-decoration` property, it works without the fix. I'm sure it works with the fix, however, in some cases the value of the property may be `line-through,line-through`.
> 
> I'll add another test if you think such a scenario is worth verifying too.

I added the backticks so it now shows the source but all I did was "s/<u>/s/"

Yes, I think it might be wise to add such a test scenario.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18550#discussion_r1558243682