RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v7]
Abhishek Kumar
abhiscxk at openjdk.org
Wed Apr 10 05:32:09 UTC 2024
On Thu, 4 Apr 2024 17:10:45 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment update
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java line 1026:
>
>> 1024: "TabbedPane.selected", tabbedPaneBg,
>> 1025: "TabbedPane.contentOpaque", Boolean.TRUE,
>> 1026: "TabbedPane.contentAreaColor", tabbedPaneBg,
>
> `TabbedPane.contentOpaque` and `TabbedPane.tabsOpaque` seems to go hand-in-hand and there's another issue for it https://bugs.openjdk.org/browse/JDK-6462396 so if we are supporting one and not other, it may not have desired effect..
@prsadhuk Handled the `TabbedPane.tabsOpaque` UI property for Synth derived LAFs. Test enhanced to check for `Content Opaque` and `Tabs Opaque` UI property behaviour. As mentioned in comment section of bug [JDK-6462396](https://bugs.openjdk.org/browse/JDK-6462396) `Note: These new properties are only honored if the JTabbedPane is non-opaque itself`, the properties are handled in same way for synth based LAFs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1558864784
More information about the client-libs-dev
mailing list