RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

Tejesh R tr at openjdk.org
Wed Apr 10 11:26:03 UTC 2024


On Wed, 10 Apr 2024 09:05:49 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Copywrite year updated
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8322140
>>  - Spacing updates
>>  - Updated test with BugID and copyright year
>>  - Fix + Revert 8210807
>
> test/jdk/javax/swing/JTable/JTableScrollPrintTest.java line 45:
> 
>> 43:  * @test
>> 44:  * @key headful
>> 45:  * @bug 8210807 8322140
> 
> Suggestion:
> 
> You may update the test with `PassFailJFrame.builder()`.
> 
> I guess `Graphics2D g2d` object needs to be disposed.

I guess here we don't have to dispose.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18187#discussion_r1559271683


More information about the client-libs-dev mailing list