RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

Tejesh R tr at openjdk.org
Wed Apr 10 11:52:18 UTC 2024


On Wed, 10 Apr 2024 08:56:08 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Copywrite year updated
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8322140
>>  - Spacing updates
>>  - Updated test with BugID and copyright year
>>  - Fix + Revert 8210807
>
> src/java.desktop/share/classes/sun/print/PathGraphics.java line 1149:
> 
>> 1147:     }
>> 1148: 
>> 1149:     public static BufferedImage convertToBufferedImage(MultiResolutionImage multiResolutionImage,
> 
> Probably the method should be declared as either `private` or `protected`, as adding a `public` method may need a CSR.
> 
> May not require to declare it as `static` too.

Updated.

> src/java.desktop/share/classes/sun/print/PathGraphics.java line 1156:
> 
>> 1154:                                                         BufferedImage.TYPE_INT_ARGB);
>> 1155:         Graphics2D g2d = bufferedImage.createGraphics();
>> 1156:         g2d.drawImage(resolutionImage, 0, 0, (int)width, (int)height, null);
> 
> Suggestion:
> 
>         g2d.drawImage(resolutionImage, 0, 0, (int) width, (int) height, null);

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18187#discussion_r1559300103
PR Review Comment: https://git.openjdk.org/jdk/pull/18187#discussion_r1559299860


More information about the client-libs-dev mailing list