RFR: 8319598: SMFParser misinterprets interrupted running status [v2]

Phil Race prr at openjdk.org
Sat Apr 13 18:16:43 UTC 2024


On Sat, 11 Nov 2023 12:32:15 GMT, Jan Trukenmüller <duke at openjdk.org> wrote:

>> The MIDI file parser misinterprets events without status byte when they appear directly after a Meta of SysEx event.
>> 
>> For my bugfix I had to decide between two possible solutions:
>> - Strict solution: Throw an InvalidMidiDataException
>> - Tolerant solution: Use the status of the last channel event as running status
>> 
>> I used the tolerant solution.
>> I will send an email to the list client-libs-dev with my reasons.
>
> Jan Trukenmüller has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reduced line lengths

This all sounds good to me but @mrserb should approve too since he was looking at it.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16546#pullrequestreview-1999326830


More information about the client-libs-dev mailing list