RFR: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ [v3]
Sergey Bylokhov
serb at openjdk.org
Tue Apr 16 07:16:01 UTC 2024
On Tue, 16 Apr 2024 04:16:26 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th reason behind this issue was the size of image which is different and that results in incorrect pixel comparison. Fix is to ensure that correct pixel is matched and the pixel color should remain within tolerance.
>> For windows LAF the background color is not an exact match and thus added a TOLERANCE field to check if the RGB difference is within limits.
>>
>> `@key headful` added in jtreg tag to ensure that test run for GTK LAF as well which was not the case before as it is mentioned in JBS `It does not fail in mach5 because on linux + headless mode the gtk L&F is not supported.`
>>
>> CI testing is green for the modified test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comment update, tolerance check removed
As far as I understand the test creates two enabled-JComboBox, then disables both, and then compares the disabled and enabled images. Why there are some differences in sizes and colors?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18644#issuecomment-2058394210
More information about the client-libs-dev
mailing list