RFR: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ [v3]
Abhishek Kumar
abhiscxk at openjdk.org
Wed Apr 17 05:20:01 UTC 2024
On Wed, 17 Apr 2024 04:25:43 GMT, Tejesh R <tr at openjdk.org> wrote:
> This condition can be optimized since the test is done for all LAF and for each this method is called twice. Instead of using ||, using && would optimized slightly. You can check for `true` where it checks for `==` and returns true. Its just a suggestion.
I think current comparison with || is ok as if any of the RGB color component doesn't match, test should fail.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18644#discussion_r1568225972
More information about the client-libs-dev
mailing list