RFR: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ [v4]
Tejesh R
tr at openjdk.org
Wed Apr 17 06:28:01 UTC 2024
On Wed, 17 Apr 2024 04:31:16 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th reason behind this issue was the size of image which is different and that results in incorrect pixel comparison. Fix is to ensure that correct pixel is matched and the pixel color should remain within tolerance.
>> For windows LAF the background color is not an exact match and thus added a TOLERANCE field to check if the RGB difference is within limits.
>>
>> `@key headful` added in jtreg tag to ensure that test run for GTK LAF as well which was not the case before as it is mentioned in JBS `It does not fail in mach5 because on linux + headless mode the gtk L&F is not supported.`
>>
>> CI testing is green for the modified test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> testDir moved to method
LGTM
-------------
Marked as reviewed by tr (Committer).
PR Review: https://git.openjdk.org/jdk/pull/18644#pullrequestreview-2005144438
More information about the client-libs-dev
mailing list