RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled

[Alexey Ivanov]

On Thu, 18 Apr 2024 05:07:04 GMT, Tejesh R <tr at openjdk.org> wrote:

> Since the changes/restructuring is more, it would be better to add more details in description which would help in review process.

What details are you looking for?

The purpose of the changes hasn't changed: make the code thread-safe in regards to managing `pageLoader`.

The changes make the code thread safe. Restructuring makes the intent clearer; eliminating long else branches is always a good thing.

Then another part of the handling which was at the very bottom of the method is moved upwards because it is relevant only if the base URL didn't change.

I haven't looked thoroughly at all the cases, yet the updated method looks better in my opinion. There could still be things to improve.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18670#issuecomment-2064200198