RFR: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected [v2]

Harshitha Onkar honkar at openjdk.org
Thu Apr 18 23:27:56 UTC 2024


On Thu, 4 Apr 2024 09:38:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test issue shows the End and Start buttons are not placed as per instructions due to ComponentOrientation RTL was not honoured, as with `getContentPane()` being removed from `add` call of JFrame, it was also additionally removed from other JFrame calls which resulted in the RTL not being propagated to its child. Fix is to add `getContentPane()` to the non-add methods of JFrame as was done in the applet version of the test..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instruction formatting

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18612#pullrequestreview-2010095658


More information about the client-libs-dev mailing list