Integrated: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
Abhishek Kumar
abhiscxk at openjdk.org
Fri Apr 19 10:14:04 UTC 2024
On Fri, 5 Apr 2024 06:54:46 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th reason behind this issue was the size of image which is different and that results in incorrect pixel comparison. Fix is to ensure that correct pixel is matched and the pixel color should remain within tolerance.
> For windows LAF the background color is not an exact match and thus added a TOLERANCE field to check if the RGB difference is within limits.
>
> `@key headful` added in jtreg tag to ensure that test run for GTK LAF as well which was not the case before as it is mentioned in JBS `It does not fail in mach5 because on linux + headless mode the gtk L&F is not supported.`
>
> CI testing is green for the modified test. Link attached in JBS.
This pull request has now been integrated.
Changeset: eb60822a
Author: Abhishek Kumar <abhiscxk at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/eb60822a45ecd076484e707b2dd1049ed9d8079b
Stats: 66 lines in 1 file changed: 19 ins; 33 del; 14 mod
8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
Reviewed-by: dnguyen, jdv, tr, serb
-------------
PR: https://git.openjdk.org/jdk/pull/18644
More information about the client-libs-dev
mailing list