RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v2]
Renjith Kannath Pariyangad
rkannathpari at openjdk.org
Fri Apr 19 12:30:26 UTC 2024
On Thu, 18 Apr 2024 16:41:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Suggesions updated
>
> src/java.desktop/share/classes/javax/swing/JEditorPane.java line 497:
>
>> 495: // we need to cancel background loading
>> 496: if (pageLoader != null) {
>> 497: pageLoader.cancel(true);
>
> Suggestion:
>
> pageLoader.cancel(true);
> pageLoader = null;
>
> Let's assign `null` to indicate there's no active `pageLoader` any more.
Updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18670#discussion_r1572292328
More information about the client-libs-dev
mailing list