RFR: 8322135: javax/swing/JTable/JTableScrollPrintTest.java & javax/swing/JTable/PrintAllPagesTest.java throws java.lang.InternalError: HTHEME is null [v5]
Tejesh R
tr at openjdk.org
Tue Apr 23 10:47:42 UTC 2024
> Getting a theme for particular dpi failed in windows L&F during print test. Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme was independent of DPI. After the fix (https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd) getting a theme in Windows L&F became dependent on DPI. Now it works fine in paint to a frame or window but for printing the DPI is computed with scaling factor which might not be w.r.t set of connected monitors and hence error is returned according to [this from windows document](https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/nf-uxtheme-openthemedatafordpi).
> The suggested fix is to handle printer cases with default dpi since in error condition 0 is returned with `openThemeImpl(widget, dpi)`. The fix seems to be working fine without causing any regression (Tested in CI systems and also the affected tests).
Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
Review updates
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18706/files
- new: https://git.openjdk.org/jdk/pull/18706/files/9c96cf68..0896dab8
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18706&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18706&range=03-04
Stats: 9 lines in 3 files changed: 0 ins; 0 del; 9 mod
Patch: https://git.openjdk.org/jdk/pull/18706.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18706/head:pull/18706
PR: https://git.openjdk.org/jdk/pull/18706
More information about the client-libs-dev
mailing list