RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]
Sergey Bylokhov
serb at openjdk.org
Tue Apr 30 05:50:05 UTC 2024
On Tue, 30 Apr 2024 02:02:30 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>> Some tests try to get the focus of a window by clicking on its title bar.
>>
>> On XWayland, however, emulating mouse clicks with XTEST currently only affects the XWayland server, not the window decorations, so trying to click on the window title will have no effect.
>>
>> So the solution is to click inside the window or call `toFront()` to get the window focused.
>>
>> Some tests have issues with AWT/Swing calls not being on EDT, it is not the goal of this change to fix them as they require way too many code changes, and make this PR hard to review.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>
> review comments
test/jdk/java/awt/Focus/6981400/Test1.java line 186:
> 184: Util.clickOnComp(compToClick, robot);
> 185:
> 186: if (Platform.isOnWayland()) {
If the goal is just to move the window to the front then can we try "toFront + click on title" on X11 and just "toFront" on Wayland?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18995#discussion_r1584163903
More information about the client-libs-dev
mailing list