RFR: JDK-8329692 : Add more details to FrameStateTest.java test instructions

Tejesh R tr at openjdk.org
Tue Apr 30 10:57:05 UTC 2024


On Mon, 29 Apr 2024 23:24:19 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> For the following manual test, more instructions are added as to what to expect for "hide,iconify and show" vs "hide,iconify,show and restore" for clarity.

One observation is that, after the updates the size of whole test window is slightly increased in height where the second Frame which has options is out of the window frame. When the taskbar is at bottom nothing seems to be visible. 
One option is to limit the instruction rows or to use `PassFailJFrame.splitUI` instead of `PassFailJFrame.splitUIBottom` (Offcourse in splitUI the second Frame occupies the whole screen length which is not required).

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java line 96:

> 94:         "hide,iconify,show and restore" case.<br><br>
> 95: 
> 96:         If you observe the proper behavior for all the combinations, press PASS else FAIL.<br>

Please limit the column length to 80, here and in some other places too.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19008#pullrequestreview-2030930422
PR Review Comment: https://git.openjdk.org/jdk/pull/19008#discussion_r1584566397


More information about the client-libs-dev mailing list