RFR: 8233068: HIDPI: Linux: AWT Checkbox check mark is unscaled [v2]

Tejesh R tr at openjdk.org
Mon Aug 5 08:59:14 UTC 2024


On Fri, 2 Aug 2024 21:23:54 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Color updation
>>  - Test condition updated + Copyright year
>
> test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 74:
> 
>> 72:                 for (int i = 0; i < imageAfterChecked.getHeight(); i++) {
>> 73:                     for (int j = 0; j < imageAfterChecked.getWidth(); j++) {
>> 74:                         if (sampleRGB != imageAfterChecked.getRGB(i, j)) {
> 
> Maybe check for the tick color (black) within the checkbox?

Yes, updated. This seems to be better than checking for unmatched case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1703774247


More information about the client-libs-dev mailing list