RFR: 8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException [v5]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Aug 5 10:09:06 UTC 2024
> When a printjob is cancelled midway, `PrinterAbortException `was not thrown in macos. because
> firstly,` cancelCheck` invokes` LWCToolkit.invokeLater` with null as parameter causing it to fail with NPE and
> secondly PrinterAbortException was consumed silently when `printLoop` throws any exception
> which is rectified to throw the PrinterAbortException when encountered..
Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
Dont call completePrintLoop if cancelDoc is called as both exits PrintingLoop
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20027/files
- new: https://git.openjdk.org/jdk/pull/20027/files/6750e51f..3ff67eb2
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20027&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20027&range=03-04
Stats: 10 lines in 1 file changed: 6 ins; 1 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/20027.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20027/head:pull/20027
PR: https://git.openjdk.org/jdk/pull/20027
More information about the client-libs-dev
mailing list