RFR: 8233068: HIDPI: Linux: AWT Checkbox check mark is unscaled [v2]

[Jayathirth D V]

On Mon, 5 Aug 2024 08:59:14 GMT, Tejesh R <tr at openjdk.org> wrote:

>> The check mark had been transformed with default scale which is 1.0 and the same is used on click of checkbox. This was done while computing the layout and not updated while paint. Hence the scaling update is done on painting the check mark and CI testing is green after the update too.
>
> Tejesh R has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Color updation
>  - Test condition updated + Copyright year

Apart from the comment i have added. Code change looks good to me.

test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 86:

> 84:             if (!checkmarkFound) {
> 85:                 try {
> 86:                     ImageIO.write(imageAfterChecked, "png",

Do we need to write this 8*8 image when this test fails? How useful will it be?
This looks like a very simply scenario where the tests will fail if nothing is filled in the checkbox.

May be we can write whole checkbox/Frame into an image, but then also i don't see  how this failure image will be helpful for debugging. If possible we should avoid writing into an image.

-------------

Marked as reviewed by jdv (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20441#pullrequestreview-2218635710
PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1703902410