RFR: 7188058: Background of TextComponents are not changing colors to the default disabled color when set to uneditable [v2]

Alisen Chung achung at openjdk.org
Mon Aug 5 17:02:36 UTC 2024


On Fri, 2 Aug 2024 03:42:51 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   moved test to awt
>
> src/java.desktop/share/classes/java/awt/TextArea.java line 613:
> 
>> 611:     public synchronized void setEditable(boolean b) {
>> 612:         super.setEditable(b);
>> 613:         Color defaultBackground = UIManager.getColor("TextArea.background");
> 
> I am not sure if it is ok to use swing "UIManager" class in awt
> I guess long time back somebody maybe @prrace mentioned that we should avoid calling swing class from awt? 
> I see we use AttributeSet in TextComponent for accessibility usage but am not sure if we can use without restriction?

This call is only to get the default background of TextArea. Is there another way to grab the default color without using UIManager?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19876#discussion_r1704404236


More information about the client-libs-dev mailing list