RFR: 8235404: [macos] JOptionPane blocks drawing string on another component [v2]

Harshitha Onkar honkar at openjdk.org
Mon Aug 5 17:59:33 UTC 2024


On Mon, 5 Aug 2024 17:28:00 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> The fix should handle both cases - when parentComponent is null and not null. With current fix, if there is a case when parentComponent is null, we will run into NPE.
>
> added null check

@alisenchung 

Shouldn't both cases be handled here? 
when parentComponent is null -  JOptionPane.showMessageDialog(null, t), it does not work in this case.
when parentComponent is NOT null -  JOptionPane.showMessageDialog(f, t)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20359#discussion_r1704459558


More information about the client-libs-dev mailing list