RFR: 8235404: [macos] JOptionPane blocks drawing string on another component [v2]

Harshitha Onkar honkar at openjdk.org
Mon Aug 5 21:05:35 UTC 2024


On Mon, 5 Aug 2024 17:01:16 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Currently if you try to use graphics to draw a string on a frame using JOptionPane + JTextField with a listener as a prompt, the string will not draw. Adding a repaint after dialog.dispose in JOptionPane will cause the text to show after the dialog is closed.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   check for null

Fix looks good except for minor spacing issues.

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java line 66:

> 64:         f.add(c);
> 65: 
> 66:         t.addActionListener(e->{

Suggestion:

        t.addActionListener(e -> {

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java line 82:

> 80:         JOptionPane.showMessageDialog(f, t);
> 81:     }
> 82: }

EOF newline misisng

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20359#pullrequestreview-2219705742
PR Review Comment: https://git.openjdk.org/jdk/pull/20359#discussion_r1704539024
PR Review Comment: https://git.openjdk.org/jdk/pull/20359#discussion_r1704539596


More information about the client-libs-dev mailing list