RFR: 8233068: HIDPI: Linux: AWT Checkbox check mark is unscaled [v3]

Abhishek Kumar abhiscxk at openjdk.org
Tue Aug 6 07:21:34 UTC 2024


On Mon, 5 Aug 2024 12:28:09 GMT, Tejesh R <tr at openjdk.org> wrote:

>> The check mark had been transformed with default scale which is 1.0 and the same is used on click of checkbox. This was done while computing the layout and not updated while paint. Hence the scaling update is done on painting the check mark and CI testing is green after the update too.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove image writing

src/java.desktop/unix/classes/sun/awt/X11/XCheckboxPeer.java line 1:

> 1: /*

You may expand wild imports.

test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 28:

> 26: import java.awt.Frame;
> 27: import java.awt.Rectangle;
> 28: import java.awt.Point;

sort the imports
Suggestion:

import java.awt.Point;
import java.awt.Rectangle;

test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 82:

> 80: 
> 81:             if (!checkmarkFound) {
> 82:                 throw new RuntimeException(" Checkmark not scaled");

minor spacing
Suggestion:

                throw new RuntimeException("Checkmark not scaled");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1705007690
PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1705008392
PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1705033710


More information about the client-libs-dev mailing list