RFR: 8321140: Add comment to note difference in Metal's JButton margins

Harshitha Onkar honkar at openjdk.org
Sat Aug 10 00:17:31 UTC 2024


On Fri, 9 Aug 2024 22:35:06 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> I found the values to be set in `BasicLookAndFeel.java` which explains why other custom L&F's are also affected. Moving the doc to there and changing this back to a public doc change can be done instead. Otherwise, I can leave it as a comment note where the value is set.

It looks okay to me to have it has a comment in MetalLAF as it is now. 

> Moving the doc to there and changing this back to a public doc change can be done instead

I think what @aivanov-jdk meant here is that since this is a comment, only the JBS title needs a change to reflect that it is a comment and not a javadoc change. Even if it is moved to BasicLAF, it would still be added as a comment, correct?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20482#issuecomment-2278900657


More information about the client-libs-dev mailing list