RFR: 6318027: BasicScrollBarUI does not disable timer when enclosing frame is disabled. [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Aug 15 07:26:28 UTC 2024


On Fri, 9 Aug 2024 06:54:27 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - copyright
>>  - Restore AquaL&F testing
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaScrollBarUI.java line 530:
> 
>> 528: 
>> 529:         public void actionPerformed(final ActionEvent e) {
>> 530:             if (fTrackHighlight != Hit.NONE && !fTrackListener.fStillInTrack) {
> 
> `fTrackListener.fStillInTrack` value is `true` and here the condition is to check for negation which makes it to `false` and overall condition evaluates to `false` and that may be the reason that the timer is not stopped.

Yes thats the drawback of indirect checking....I have modified PR to check for frame disable directly and stop the timer..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20346#discussion_r1718061735


More information about the client-libs-dev mailing list