RFR: 8321140: Add comment to note difference in Metal's JButton margins
Damon Nguyen
dnguyen at openjdk.org
Thu Aug 15 19:06:49 UTC 2024
On Thu, 15 Aug 2024 18:06:49 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java line 810:
>>
>>> 808: "released SPACE", "released"
>>> 809: }),
>>> 810: // margin is (2, 14, 2, 14) which is vastly larger in horizontal
>>
>> I see below that there is another comment saying margin is 2 all the way around, what is the difference? how are these comments placed to indicate what margins they are referring to?
>
> The below comments apply to check box and radio button; this comment applies to regular push button.
Yep. The issue is with regular buttons as Alexey mentioned. This caused a long discussion chain described in the linked issues. Nothing to do with CheckBox or RadioButton.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20482#discussion_r1718868474
More information about the client-libs-dev
mailing list