RFR: 8332901: Choice/SelectCurrentItemTest/SelectCurrentItemTest.java doesn't open popup on macOS [v2]

Damon Nguyen dnguyen at openjdk.org
Mon Aug 19 18:32:48 UTC 2024


On Mon, 19 Aug 2024 13:57:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I looked at `java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.java`, ran it and noticed that the test does not open the popup of the `Choice` component on macOS 14.x.
>> 
>> If the popup does not open, the test does not verify anything — it always passes.
>> 
>> I refactored the test and added a mouse listener to the `Choice` component. If mouse click isn't registered, the test fails.
>> 
>> The updated test fails for me locally on macOS Sonoma 14.5. This is likely the result of [JDK-8322653](https://bugs.openjdk.org/browse/JDK-8322653): _[macos14] : Mouse clicks are not received within 3 pixels of the window boundary_.
>> 
>> The updated test passes on CI.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make frame non-resizable to workaround JDK-8322653

LGTM as well

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/20601#pullrequestreview-2246203092


More information about the client-libs-dev mailing list