RFR: 4795384: GTK+ JFileChooser buttons should have mnemonics [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Aug 20 06:40:52 UTC 2024


On Tue, 20 Aug 2024 05:39:20 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JDK-8080628 removes these Save and Open mnemonics from gtk and it does from all locales, not only the default locale, I guess for some customer escalation, so it needs to be verified with the fix author if it will regress the expectation.
>> 
>> If you want to reinstate the mnemonics, then I guess it needs to be reinstated for all locales gtk_de.properties, gtk_es.properties, gtk_fr.properties etc simultaneously
>
>> JDK-8080628 removes these Save and Open mnemonics from gtk and it does from all locales, not only the default locale, I guess for some customer escalation, so it needs to be verified with the fix author if it will regress the expectation.
> 
> Ok.
> 
>> If you want to reinstate the mnemonics, then I guess it needs to be reinstated for all locales gtk_de.properties, gtk_es.properties, gtk_fr.properties etc simultaneously
> 
> 
> I guess only `gtk.properties` needs to update and other locale should be taken care by g11n process as mentioned in one of my previous [PR](https://github.com/openjdk/jdk/pull/9327#discussion_r911212025).

Not sure if it still valid as I guess team doesn't exist anymore and probably Damon is doing the translations now but you can check..I brought it up since JDK-8080628 remove under one PR...so even if g11n process does it, it needs to be done offline and placed under this PR, I presume..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20612#discussion_r1722765172


More information about the client-libs-dev mailing list