RFR: 8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS [v4]

[Alexey Ivanov]

On Tue, 20 Aug 2024 15:20:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Amend the copyright year in SelectCurrentItemTest
>
> Unfortunately, Git does not recognise the files are moved with so many additional changes.
> 
> As a workaround, I can submit a new issue and integrate it where the files are moved only. This way we could preserve the history of the changes to the tests.
> 
> Do you have any opinions?

> @aivanov-jdk Does it work if you move the test files using `git mv`, commit it and in the next commit modify the files
> I mean 2 separate commits - one for move and another one that modifies the files.

That's exactly what I did if you look at the history of the commits.

It doesn't work in the code review. It won't work after integration either.

After integration, individual commits are lost, everything is squashed into one changeset.

The only reliable way to preserve the history across renames (and modification) is to integrate a separate changeset where the files are only renamed without any modifications.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20601#issuecomment-2299331866