RFR: 8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F [v2]

Harshitha Onkar honkar at openjdk.org
Thu Aug 22 22:15:07 UTC 2024


On Thu, 22 Aug 2024 21:24:50 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Updated review comments
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8338041
>>  - Test updates
>>  - Key action modified + Automatic test added
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java line 1062:
> 
>> 1060:                        "shift KP_RIGHT", "selectNextColumnExtendSelection",
>> 1061:                      "ctrl shift RIGHT", "selectLastColumnExtendSelection",
>> 1062:                   "ctrl shift KP_RIGHT", "selectNextColumnExtendSelection",
> 
> should KP_RIGHT also be changed to selectLastColumnExtendSelection? Should keypad shortcuts be identical to the arrow key shortcuts?

Good catch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20608#discussion_r1727982100


More information about the client-libs-dev mailing list