RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work [v3]

Damon Nguyen dnguyen at openjdk.org
Thu Aug 22 23:57:04 UTC 2024


On Tue, 30 Jul 2024 05:17:12 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Mismatch in key combinations, I have taken native macos Numbers application as reference to verify. Have added `Ctrl-Shift Left/Right` action keys similar to `Ctrl-Shift UP/DOWN` which would be expected functionality. I've removed those test instructions which are not applicable/implemented/not working in Macos keyboard navigation.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

If the test window (not the instruction window) can't be expanded more, then LGTM. The test window has a vertical scroll (which is fine), but also a horizontal scroll (which can be avoided by expanding the width a bit more).

Tested all of the instructed key combinations on a Mac device. All works as described with the changes.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/20331#pullrequestreview-2255979897


More information about the client-libs-dev mailing list