RFR: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F

Abhishek Kumar abhiscxk at openjdk.org
Fri Aug 23 06:56:08 UTC 2024


On Thu, 22 Aug 2024 21:32:08 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This test should have failed with the [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't because GTK look and feel isn't supported in headless environment.
>> 
>> Fix is to run the test with headful environment on linux platform. 
>> 
>> Tested in CI pipeline and link attached to JBS.
>
> test/jdk/javax/swing/JFileChooser/8080628/bug8080628.java line 46:
> 
>> 44:  * @key headful
>> 45:  * @summary No mnemonics on Open and Save buttons in JFileChooser.
>> 46:  * @requires os.family == "linux"
> 
> Looks like jtreg tags were accidentally duped. Did you mean to only replace the author tag with the requires tag?

@alisenchung As @honkar-jdk explained this is to run different configuration for different platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20671#discussion_r1728463547


More information about the client-libs-dev mailing list