RFR: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F [v2]

Alexey Ivanov aivanov at openjdk.org
Fri Aug 23 09:54:05 UTC 2024


On Fri, 23 Aug 2024 09:21:02 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/8080628/bug8080628.java line 1:
>> 
>>> 1: /*
>> 
>> Could you also clean up the main method and remove the extra overhead in the SwingUtilities.invokeAndWait call? Also remember to update copyright years
>
> I think that is ok.. it's pretty simple where runnable interface run method is overridden and is supposed to run the test.
> copyright year updated.

What do you mean? Replacing `new Runnable` with lambda?

Does it add value? Sure the code becomes shorter… However, the test still does its job. And IDE still shows the compact version displaying the body of the `run` method only.

Given that no other code is changed, except for adding additional output, I'd rather keep it as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20671#discussion_r1728705048


More information about the client-libs-dev mailing list